-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Clippy #83012
Update Clippy #83012
Conversation
…r=camsteffen added new lint `owned_to_owned` Adding new lint `owned_to_owned` Creating draft PR to have this looked over. I think this takes all advice I received into account. I did have to update the `redundant_clone` test to ignore this lint -- I felt that was the safest action. closes: rust-lang#6715 changelog: added new lint `implicit_clone`
Fix ICEs 6792 and 6793 fixes rust-lang#6792, fixes rust-lang#6793. r? `@matthiaskrgr` Fixes the ICEs by replacing `TyCtxt::type_of` with `TypeckResults::expr_ty`. changelog: none
Remove workspace and fix dogfood (again) changelog: none In response to rust-lang/rust-clippy#6733 (comment)
…ith the diagnostics convention of the rustc dev guide lint message should not start with uppercase letters lint messages should not have punctuation at the end of the last line https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-structure The test reads through all the .stderr files in the testsuit and checks lint messages that start with "help: ", "error: " etc. There is also an exception list for special messages that are deemed acceptable. changelog: make sure lint messages conform with the rustc dev guide and add test
tests: add test that roughly ensures that our lint messages conform with the diagnostics convention of the rustc dev guide lint message should not start with uppercase letters lint messages should not have punctuation at the end of the last line https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-structure The test reads through all the .stderr files in the testsuit and checks lint messages that start with "help: ", "error: " etc. There is also an exception list for special messages that are deemed acceptable. changelog: make sure lint messages conform with the rustc dev guide and add test
…olds the job limit and paths to the sources and log files
…o the source files of a warning into the lintcheck log This is more convenient when reviewing new lint warnings that popped up in the logs
Update Clippy Bi-weekly Clippy sync. r? `@Manishearth`
Failed in rollup: #83038 (comment) |
@bors rollup=iffy |
Uh that looks weird. In the rust->Clippy sync direction, I was told to add them. Seems like something changed here and those parentheses aren't necessary anymore? Just seems like unfortunate timing. I will fix this tomorrow. |
This comment has been minimized.
This comment has been minimized.
This will be removed in the next sync, once beta is at 1.52. Until then this hack avoids to put `cfg(bootstrap)` into Clippy.
@Manishearth This should now be ready. 99d0519 fixed the issue. I could've also fixed it by putting |
@bors r+ Good call |
📌 Commit 99d0519 has been approved by |
Update Clippy Bi-weekly Clippy sync. r? `@Manishearth`
Rollup of 6 pull requests Successful merges: - rust-lang#82984 (Simplify ast block lowering) - rust-lang#83012 (Update Clippy) - rust-lang#83020 (Emit the enum range assumption if the range only contains one element) - rust-lang#83037 (Support merge_functions option in NewPM since LLVM >= 12) - rust-lang#83052 (updated vulnerable deps) - rust-lang#83059 (Allow configuring `rustdoc --disable-minification` in config.toml) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Bi-weekly Clippy sync.
r? @Manishearth